Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated the filtering condition on GameServerShutdown to include the undeleted Unhealthy GSs #740

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Updated the filtering condition on GameServerShutdown to include the undeleted Unhealthy GSs #740

merged 1 commit into from
Apr 25, 2019

Conversation

ilkercelikyilmaz
Copy link
Contributor

Fixed the filtering condition on GameServerShutdown to include the undeleted Unhealthy GSs.
After the change the Unhealthy servers are (eventually) being deleted(see the graph below).

Also remove the WaitForCacheSync call during the GS creation. This improves the allocation and overall performance.

image

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0bbec6bf-fd94-4b26-a64b-11df9ae5b4a4

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: c66af9bd-c543-4fa5-bbd2-f3b441c61b62

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-947799e

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 9349ae97-0c4c-4205-8ed6-a36c18aa68a9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0804600

markmandel
markmandel approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🎁

markmandel
markmandel requested changes Apr 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, sorry - can we squish this to one commit plz?

@ilkercelikyilmaz
Copy link
Contributor Author

Oops, sorry - can we squish this to one commit plz?

Done

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 65c32438-c1c8-49e7-816a-9bf822ab5047

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/740/head:pr_740 && git checkout pr_740
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-72ca155

markmandel
markmandel approved these changes Apr 25, 2019
View reviewed changes
Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 💪

@markmandel markmandel merged commit 83a3e04 into googleforgames:master Apr 25, 2019
@markmandel markmandel added area/performance Anything to do with Agones being slow, or making it go faster. kind/bug These are bugs. labels Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
@ilkercelikyilmaz ilkercelikyilmaz mentioned this pull request May 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markmandel markmandel markmandel approved these changes

Assignees
No one assigned
Labels
area/performance Anything to do with Agones being slow, or making it go faster. kind/bug These are bugs.
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ilkercelikyilmaz @agones-bot @googlebot @markmandel